Index guard for turn lookup to prevent error messages #5846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an index guard to Game.getTurnForPlayer() to prevent frequent log error messages. getTurnForPlayer() is called from Client.isMyTurn() when the phase is simultaneous which is the case for the PRE_* phases (activating hidden units). A similar guard is already present for Game.getTurn() which is used for non-simultaneous phases.
Removed the synchronized as MM is not multithreaded, even when simultaneous turns are used (and please let's keep it that way)