Force destruction of out-of-control DropShips and larger #5845
Conversation
| @@ -207,9 +206,9 @@ public MovePath addStep(final MoveStepType type, final boolean noCost) { | |||
| } | |||
|
|
|||
| public MovePath addStep(final MoveStepType type, final Map<Integer, Integer> additionalIntData) { | |||
| return addStep(new MoveStep(this, type, additionalIntData)); | |||
| return addStep(new MoveStep(this, type, additionalIntData)); | |||
There was a problem hiding this comment.
IDEA just reallllly disliked the formatting in this file.
| @@ -4898,6 +4898,7 @@ else if (game.getBoard().onGround()) { | |||
| private Vector<Report> processCrash(Entity entity, int vel, Coords c) { | |||
| Vector<Report> vReport = new Vector<>(); | |||
| Report r; | |||
| boolean destroyDropShip = false; // save for later | |||
| // If out of control, destruction (of DropShips and larger) is assured. | ||
| destroyDropShip = (entity instanceof Dropship || entity instanceof Jumpship) | ||
| && ((IAero) entity).isOutControlTotal(); | ||
|
|
||
| // Technically bring to a halt; actual landing is handled elsewhere. |
| if (destroyDropShip) { | ||
| // Out-of-control DropShip that crashes is automatically destroyed. | ||
| r = new Report(9708, Report.PUBLIC); | ||
| r.indent(); | ||
| r.addDesc(entity); | ||
| vReport.addAll(destroyEntity(entity, "Crashed while out of control!")); | ||
| } | ||
|
|
There was a problem hiding this comment.
New code part 3; actually finishes the job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5845 +/- ##
============================================
- Coverage 28.99% 28.99% -0.01%
Complexity 13930 13930
============================================
Files 2512 2512
Lines 267279 267289 +10
Branches 47833 47837 +4
============================================
+ Hits 77509 77510 +1
- Misses 185820 185829 +9
Partials 3950 3950 ☔ View full report in Codecov by Sentry. |
I can add an option to turn this rule off, but as a reminder, it's only for Large Craft crashing while out of control. If they crash due to loss of thrust or some other reason, they'll be treated as before. |
Sleet01
force-pushed
the
Fix_770_destroy_crashing_out_of_control_DSes
branch
from
8af3671 to
a55a508
Compare
This is the final step to completing the Errata from #770: enforce destruction of DropShips (and larger) that crash while out of control.
Note: this may be gilding the lily, as the chances of most DropShips surviving crashes is slim already. But this will ensure that, after all damage is dealt and terrain is re-arranged, the crashing unit will be utterly kaput.
Testing:
Close #770