Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5825: ASF Low Altitude LOS, levels, and ground map terrain blocking other terrain #5838

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Aug 1, 2024

Reverted some low-altitude map changes, extracted relevant code to Low Alt-specific functions, and updated some LOS measuring and drawing functions to work with Altitudes. Marking as Draft for now so more testing can get run.

Current visuals look like:
image
image

With Diagramming LOS:
image

Testing so far:

  • Ran human-vs-bot ASF games on Low Altitude maps
  • Ran all 3 projects' unit tests

Close #5825

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.00%. Comparing base (ac6e56a) to head (7586dde).
Report is 68 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5838      +/-   ##
============================================
- Coverage     29.07%   29.00%   -0.08%     
+ Complexity    13937    13927      -10     
============================================
  Files          2507     2511       +4     
  Lines        266470   267223     +753     
  Branches      47652    47822     +170     
============================================
+ Hits          77477    77507      +30     
- Misses       185042   185768     +726     
+ Partials       3951     3948       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez
Copy link
Member

SJuliez commented Aug 1, 2024

Ready for review? You wrote that this was marked as draft but it isnt.

@Sleet01 Sleet01 marked this pull request as draft August 1, 2024 17:15
@Sleet01
Copy link
Collaborator Author

Sleet01 commented Aug 1, 2024

Ready for review? You wrote that this was marked as draft but it isnt.

Sorry, that's the 2AM brain talking. I'll mark it as draft and get some more testing in.

@pokefan548
Copy link
Contributor

Did some testing clients-akimbo on a snapshot provided by Sleet. Rigorous testing of vanilla LOS, and some brief testing of Diagramming and Dead Zone LOS rules. All results point to everything working as intended.

@Sleet01
Copy link
Collaborator Author

Sleet01 commented Aug 2, 2024

I also got some more testing in, although some just proved that the previous code was busted. Ready to pull.

@Sleet01 Sleet01 marked this pull request as ready for review August 2, 2024 04:00
@Sleet01 Sleet01 merged commit cfbe302 into MegaMek:master Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOS Being Drawn At Incorrect Altitudes On Low-Alt Map
3 participants