Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameReports: remove error message and deal with missing rounds #5836

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Aug 1, 2024

This removes the unnecessary error message for getting a non-existent round report and instead just returns an empty list.

Since the round reports are just a list, not a map of round->reports, they are brittle. But as long as every round gets a report, it works.

This is one of the issues in #5833

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.01%. Comparing base (d349884) to head (12a525f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5836   +/-   ##
=========================================
  Coverage     29.01%   29.01%           
- Complexity    13923    13927    +4     
=========================================
  Files          2511     2511           
  Lines        267117   267114    -3     
  Branches      47784    47784           
=========================================
+ Hits          77504    77508    +4     
+ Misses       185661   185658    -3     
+ Partials       3952     3948    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 07835e7 into MegaMek:master Aug 1, 2024
5 checks passed
@SJuliez SJuliez deleted the turn-1 branch October 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants