#5811 Some validation rules and illegal design quirk

[SJuliez]

• adds a few tests to unit validation
• adds a check for the Illegal Design quirk which will make validation pass even when there are errors; the heavy gameplay penalties of this quirk are not implemented currently
• adds missing quirks to some units of XTRO Caveat Emptor
• updates the mechview to show errors with a different header when the illegal design quirk is present
• removes a redundant override from the various TestXYZ classes

Fixes #5811

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.05%. Comparing base (36da675) to head (083f37f).
Report is 28 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5828      +/-   ##
============================================
- Coverage     29.06%   29.05%   -0.01%     
+ Complexity    13911    13895      -16     
============================================
  Files          2507     2507              
  Lines        266343   266380      +37     
  Branches      47612    47628      +16     
============================================
- Hits          77400    77394       -6     
- Misses       185021   185045      +24     
- Partials       3922     3941      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pavelbraginskiy]

As mentioned in #5811 (comment), the RISC Hyper Laser is another piece of equipment that should require a nuclear engine. Could you add a check for that as well?

IO:AE p87

[NickAragua]

Do we have the horrific drawbacks that come with the Illegal Design quirk?

[pavelbraginskiy]

Do we have the horrific drawbacks that come with the Illegal Design quirk?

the heavy gameplay penalties of this quirk are not implemented currently

[SJuliez]

As mentioned in #5811 (comment), the RISC Hyper Laser is another piece of equipment that should require a nuclear engine. Could you add a check for that as well?

IO:AE p87

TestMech already contains a test for the RHL. I didn't try it out. I suppose you tried it and it validated?

[pavelbraginskiy]

As mentioned in #5811 (comment), the RISC Hyper Laser is another piece of equipment that should require a nuclear engine. Could you add a check for that as well?
IO:AE p87

TestMech already contains a test for the RHL. I didn't try it out. I suppose you tried it and it validated?

I tried it with an ICE vehicle and MML said it was valid. Maybe it only checks it on mechs or something like that?