Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5691: Add safety checks to each dialog call in the load-button handling #5815

Merged

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jul 28, 2024

There was no code path handling cancellation or dealing with null objects.
Adds three such checks.

Testing:

  • Tested with save file provided in issue
  • Ran all 3 projects' unit tests

Close #5691

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.05%. Comparing base (36da675) to head (d038e37).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5815      +/-   ##
============================================
- Coverage     29.06%   29.05%   -0.01%     
+ Complexity    13911    13909       -2     
============================================
  Files          2507     2507              
  Lines        266343   266364      +21     
  Branches      47612    47620       +8     
============================================
- Hits          77400    77398       -2     
- Misses       185021   185029       +8     
- Partials       3922     3937      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit 305448d into MegaMek:master Jul 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when cancelling loading a unit onto another unit
2 participants