Use best hex for FoV highlighting for multi-hex units #5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5809 +/- ##
============================================
- Coverage 29.06% 29.06% -0.01%
- Complexity 13907 13913 +6
============================================
Files 2507 2507
Lines 266333 266339 +6
Branches 47605 47611 +6
============================================
- Hits 77421 77403 -18
- Misses 184987 185012 +25
+ Partials 3925 3924 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FoV highlighting was not considering secondary positions. Fixes #5785
This also adds a little test scenario with a grounded DS which is going to continue to work in the next version (unlike a savegame).