Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent units from unloading over bay door limits #5808

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Jul 27, 2024

Fixes #5793

  • Now respects bay door limits by filtering correctly (removed the nonsensical assignment in MovementDisplay)
  • Removes a method in Entity that was used nowhere and some minor code/comment cleanups

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.06%. Comparing base (f7b39ab) to head (5074792).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5808      +/-   ##
============================================
- Coverage     29.06%   29.06%   -0.01%     
- Complexity    13907    13911       +4     
============================================
  Files          2507     2507              
  Lines        266333   266326       -7     
  Branches      47605    47602       -3     
============================================
- Hits          77421    77400      -21     
- Misses       184987   185004      +17     
+ Partials       3925     3922       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit 50b935c into MegaMek:master Jul 28, 2024
5 checks passed
@SJuliez SJuliez deleted the bay-unload branch August 1, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Ship Doors and Bays and Unloading Issues
2 participants