Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lobby copy paste for empty model units #5806

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Jul 27, 2024

Fixes #5740
hopefully this time. Empty models weren't considered properly. Also, the StringTokenizer skipped empty tokens.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.06%. Comparing base (f7b39ab) to head (25f0675).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5806      +/-   ##
============================================
- Coverage     29.06%   29.06%   -0.01%     
  Complexity    13907    13907              
============================================
  Files          2507     2507              
  Lines        266333   266330       -3     
  Branches      47605    47610       +5     
============================================
- Hits          77421    77396      -25     
- Misses       184987   185008      +21     
- Partials       3925     3926       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit fde43fd into MegaMek:master Jul 28, 2024
5 checks passed
@SJuliez SJuliez deleted the lobby-coppy-paste-revisit branch August 1, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying and Pasting Clan units in the lobby
2 participants