Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reflective armor not appearing in MML dropdown #5798

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jul 26, 2024

This was brought up during a conversation on #5795 but did not get its own bug.
The issue is that IS and Clan Reflective Armor did not have the flag marking it as available for Aerospace Fighters and Conventional Fighters, despite many examples of both with Reflective Armor existing (and validating correctly).
This bug has probably existed a long time, but was exposed by the recent refactoring of Armor and Equipment types.

Testing:

  • Built new ASF and CF units with Reflective
  • Loaded existing ASF and CF units with Reflective
  • Ran all 3 projects' unit tests

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.06%. Comparing base (d101f3c) to head (39e5e79).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5798      +/-   ##
============================================
- Coverage     29.07%   29.06%   -0.01%     
  Complexity    13912    13912              
============================================
  Files          2507     2507              
  Lines        266331   266360      +29     
  Branches      47605    47611       +6     
============================================
+ Hits          77426    77427       +1     
- Misses       184985   185010      +25     
- Partials       3920     3923       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit d4c9991 into MegaMek:master Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants