Fix #5795: Implement TW LOS and Forest rules for Low Altitude maps #5797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this has been broken since before 0.48.0, maybe since 2003: we have been treating Low-Altitude map terrain as if it were Ground Map terrain, which means it never obscures Aerospace units from each other.
Buildings and landed Dropships (which are treated as buildings) should not obscure lines of site between any Aero units using Altitude on a Low-Altitude map.
Additionally, forests should only rise 1 level above the terrain they are on when Low Altitude maps are created from Ground Maps - thankfully the Hex class provides a mechanism to tweak this stat for forest / jungle / foliage hexes.
Total Warfare p. 81 says:
Unfortunately it was much simpler to reverse the normal conversion and use the units' Altitudes as Elevation, rather than convert Elevation into Altitudes, due to the way that LosEffects is written.
Testing:
Close #5795