Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Sprite-Swap #5794

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fixes Sprite-Swap #5794

merged 1 commit into from
Jul 25, 2024

Conversation

repligator
Copy link
Collaborator

Fixes #5661
Credit to @SJuliez for the fix.

All MM tests passed or ignored.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.06%. Comparing base (d101f3c) to head (f7b39ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5794      +/-   ##
============================================
- Coverage     29.07%   29.06%   -0.01%     
+ Complexity    13912    13907       -5     
============================================
  Files          2507     2507              
  Lines        266331   266333       +2     
  Branches      47605    47605              
============================================
- Hits          77426    77421       -5     
- Misses       184985   184987       +2     
- Partials       3920     3925       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit c96a55b into MegaMek:master Jul 25, 2024
5 checks passed
@repligator repligator deleted the Sprite-Swap-4real branch August 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprite (including camo) swap in the phase report/log
3 participants