Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Validation Utility Fix. #5775

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

rjhancock
Copy link
Collaborator

Removed lines that were duplicated left/right
Refactored Utility to DRY up the code.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (3f92104) to head (76fdc5c).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5775      +/-   ##
============================================
- Coverage     29.07%   29.07%   -0.01%     
+ Complexity    13909    13907       -2     
============================================
  Files          2507     2507              
  Lines        266309   266306       -3     
  Branches      47598    47597       -1     
============================================
- Hits          77421    77418       -3     
- Misses       184968   184970       +2     
+ Partials       3920     3918       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 2254f48 into MegaMek:master Jul 23, 2024
6 checks passed
@rjhancock rjhancock deleted the name_validator_fixes branch July 23, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants