Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make help dialog content paths compatible with various OSes #5767

Merged

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jul 22, 2024

Compiles various help file paths into MMConstants and wraps them in calls to Paths.get().toString() for wider compatility.

Testing:

  • Opened the help dialogs in MegaMek
  • Ran all 3 projects' unit tests

Close #4301

@Sleet01 Sleet01 requested a review from HammerGS July 22, 2024 02:39
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (61fa436) to head (3c591be).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5767      +/-   ##
============================================
- Coverage     29.07%   29.07%   -0.01%     
+ Complexity    13908    13907       -1     
============================================
  Files          2507     2507              
  Lines        266290   266309      +19     
  Branches      47598    47598              
============================================
- Hits          77420    77418       -2     
- Misses       184951   184973      +22     
+ Partials       3919     3918       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit 7049eb7 into MegaMek:master Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Help Available: error reading readme.txt
3 participants