Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up Utility classes with Gradle build #5750

Merged
merged 17 commits into from
Jul 20, 2024

Conversation

rjhancock
Copy link
Collaborator

Allow using Gradle to handle utilities classes for use.
Updated Gradle to 8.9
Removed a deprecation related to testing frameworks.
Removed build scripts no longer needed (replaced by build command)
Added output of mm-revision.txt file
Re-added Launch4J ini file.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.08%. Comparing base (cfbb830) to head (7a53366).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5750      +/-   ##
============================================
- Coverage     29.08%   29.08%   -0.01%     
- Complexity    13901    13906       +5     
============================================
  Files          2507     2507              
  Lines        266110   266160      +50     
  Branches      47579    47586       +7     
============================================
+ Hits          77404    77409       +5     
- Misses       184786   184836      +50     
+ Partials       3920     3915       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjhancock rjhancock marked this pull request as ready for review July 20, 2024 04:22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a generated file? This change would get overwritten when generated right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets updated when Gradle gets updated, no other time.

Copy link
Collaborator

@HoneySkull HoneySkull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, (I'm assuming the gradlew file only gets generated on project creation - so that should be good.)

@HammerGS HammerGS merged commit e7a0a93 into MegaMek:master Jul 20, 2024
6 checks passed
@rjhancock rjhancock deleted the utilities-in-gradle branch July 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants