Fix CF warning sprite to work with isometric view. #5014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a minor gui cleanup. The feature works in isometric view and non-isometric view - it just didn't update when toggling between the two. (If one would select a different entity in deploy or movement phase, it would then update correctly.) |
NickAragua
approved these changes
Jan 8, 2024
HammerGS
added a commit
that referenced
this pull request
Jan 9, 2024
+ PR #5024: Mech summary invalid + PR #5023: Correct conversion exception causing search to not work + Fix #5015: Add advanced search for gyro + PR #5014: Fix CF warning sprite to work with isometric view + PR #5012: QuirkEntry: remove maximum slot number check (fixes MegaMekLab#1364) + PR #4992: Don't display engine rating for SV engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CF Warning rendering for isometric view. Specifically when toggling back and forth between isometric and normal rendering. The warning signs were not being updated to the correct elevation on toggle.
should be: