add report roll tooltip #4873
Merged
add report roll tooltip #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kuronekochomusuke
commented
Nov 4, 2023
•
kuronekochomusuke
commented
- add report roll tooltip for piloting and gunnery skill checks
- add report roll tooltip to more of the reported rolls
kuronekochomusuke
added
Reports
|
Love this. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kuronekochomusuke
removed
the
In Development (Draft)
HoneySkull
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Design question: Would it be beneficial to overload the Report::add() function to take a Roll parameter so that it can automatically addDataWithToolTip(roll.getIntValue(), roll.getReport()) - in such a way that by default tooltips get generated? It goes against Demitre's law a little because Report would need to know about Roll - but there is a LOT of reporting code intermingled within the game logic -but tool tips are part of reporting.
|
I think it would make things a little cleaner in game logic parts of the code. just need to see what impacts returning roll in some of the edge cases, but in general it seems an easy change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.