Fix machine gun array burst damage against conventional infantry #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| damage = applyGlancingBlowModifier(damage, true); | ||
| if (game.getOptions().booleanOption(OptionsConstants.ADVCOMBAT_TACOPS_RANGE)) { | ||
| if (nRange > wtype.getRanges(weapon)[RangeType.RANGE_LONG]) { | ||
| damage *= 0.75; |
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment High
| if (nRange > wtype.getRanges(weapon)[RangeType.RANGE_LONG]) { | ||
| damage *= 0.75; | ||
| } else if (nRange > wtype.getRanges(weapon)[RangeType.RANGE_EXTREME]) { | ||
| damage *= 0.5; |
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment High
|
Closed because of cruft in the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Against most units a machine gun array rolls on the cluster hits table to determine the number of weapons that hit. Against conventional infantry the number of burst damage dice is supposed to be multiplied by the number of linked weapons.
I've also modified the report to show the amount of damage done by any burst weapon.
1D6/2 is not an issue because it is only used by BA weapons, and cannot be part of a MGA.
Fixes #4745.