Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestTank: Adapt some tests for GunEmplacements #4816

Merged
merged 1 commit into from
Oct 9, 2023
Merged

TestTank: Adapt some tests for GunEmplacements #4816

merged 1 commit into from
Oct 9, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 1, 2023

Makes Gun Emplacements no longer show as invalid after configuring them in the lobby

@HammerGS HammerGS merged commit b029978 into MegaMek:master Oct 9, 2023
HammerGS added a commit that referenced this pull request Oct 9, 2023
@HammerGS
Various fixes.
9eae7f2 
+ Fix #4820: Fix Immelman and Split-S maneuvers
+ PR #4818: Separate structure class from TestEntity
+ PR #4816: TestTank: Adapt some tests for GunEmplacements
@SJuliez SJuliez deleted the gunEmp_invalid branch October 14, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAragua NickAragua NickAragua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SJuliez @NickAragua @HammerGS