Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerospace landing fixes #4813

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Aerospace landing fixes #4813

merged 8 commits into from
Oct 3, 2023

Conversation

neoancient
Copy link
Member

Fixes several issues related to aerospace units making landings:

  1. Units making vertical landings only apply half the terrain modifier (TW, p. 87).
  2. I added terrain modifiers for advanced terrain from TacOps.
  3. When the landing path includes rough or rubble terrain, the landing unit takes damage (TW, p. 86, table).
  4. A unit that lands in water of sufficient depth (2 for dropships, 1 for other units) is destroyed (TW p. 87, which refers to p. 82).
  5. A dropship that lands in depth 1 water is immobile for the rest of the game (ibid).

I exempted LAMs and units with a flotation hull from water destruction.
Fixes #4743

Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in "landing gear" of the messages.properties. The footnote text in the table of TW p.86 suggests adding only the highest terrain modifier which would contradict the text of p.87. Seems to me to make sense doing it like the text says. So, all ok.

@SJuliez SJuliez merged commit 8ec42e4 into master Oct 3, 2023
4 of 5 checks passed
@neoancient neoancient deleted the aero_landing branch December 12, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various Aerospace Issues - Aero V-Landing Does Not Apply Modifiers Correctly, Addtl issue with water.
2 participants