Fix #4790: uncaught NPE when Sniper Turret fired on fleeing off-board target #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAragua
requested changes
Sep 26, 2023
megamek/src/megamek/common/weapons/ArtilleryWeaponIndirectFireHandler.java
Outdated
Show resolved
Hide resolved
NickAragua
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is that target is null by the time we get around to handling this indirect attack, because it has fled already.
Fix is to ignore this failure and just log the incident, as there doesn't seem to be any way to resolve damage from a missed counter-battery attack on an off-board target that has fled.
Tested by implementing this code in 0.49.14 and running OP's save file past the point that previously got hung.
close #4790