fix: Fix Navigation Url when external link - MEED-7881 - Meeds-io/meeds#2622 #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds#2622 Prior to this change, the external link behavior wasn't the same switch Navigation Node display mode: - Desktop Menu Item - Desktop Menu Sub item (displayed in Second or Third Level) - Mobile Menu Item - Mobile Menu Sub item (displayed in Second or Third Level) Thus, when clicking on external link in Mobile, the behavior is just to open the URL as it was a current page URL. This change will introduce the usage of **AutoLink** API in order to ensure the URL behavior consistency comparing to provided link by the user. In addition, when a Dash is used in user provided URL, the behavio has been improved to always open the URL and not let the builtin behavior occurs, which will not change to the opened page.
|
AzmiTouil
approved these changes
Dec 3, 2024
exo-swf
pushed a commit
that referenced
this pull request
Dec 3, 2024
…ds#2622 (#4215) Prior to this change, the external link behavior wasn't the same switch Navigation Node display mode: - Desktop Menu Item - Desktop Menu Sub item (displayed in Second or Third Level) - Mobile Menu Item - Mobile Menu Sub item (displayed in Second or Third Level) Thus, when clicking on external link in Mobile, the behavior is just to open the URL as it was a current page URL. This change will introduce the usage of **AutoLink** API in order to ensure the URL behavior consistency comparing to provided link by the user. In addition, when a Dash is used in user provided URL, the behavior has been improved to always open the URL and not let the builtin behavior occurs, which will not change to the opened page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the external link behavior wasn't the same switch Navigation Node display mode:
Thus, when clicking on external link in Mobile, the behavior is just to open the URL as it was a current page URL. This change will introduce the usage of AutoLink API in order to ensure the URL behavior consistency comparing to provided link by the user. In addition, when a Dash is used in user provided URL, the behavior has been improved to always open the URL and not let the builtin behavior occurs, which will not change to the opened page.