feat: Avoid using Profile Setting Administration for AboutMe and Experiences Profile fields - MEED-7810 - Meeds-io/meeds#2577 #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riences Profile fields - MEED-7810 - Meeds-io/meeds#2577 Prior to this change, the User Profile fields 'AboutMe' and 'experiences' was controlled by ProfileSettingService API which was considered due to Meeds-io/si#3 issue. This change will avoid using such control explicitely on 'AboutMe' and 'Experiences' field since it's displayed in dedicated sections in the profile page of the user, and thus will be displayed all time for all users when not empty.
|
AzmiTouil
approved these changes
Nov 15, 2024
exo-swf
pushed a commit
that referenced
this pull request
Nov 15, 2024
…riences Profile fields - MEED-7810 - Meeds-io/meeds#2577 (#4194) Prior to this change, the User Profile fields `AboutMe` and `experiences` was controlled by `ProfileSettingService` API which was considered due to Meeds-io/si#3 issue. This change will avoid using such control explicitly on 'AboutMe' and 'Experiences' field since it's displayed in dedicated sections in the profile page of the user, and thus will be displayed all time for all users when not empty. At the same time, the field `gender` isn't retrieved automatically in Profile REST calls since it's deprecated functionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the User Profile fields
AboutMeandexperienceswas controlled byProfileSettingServiceAPI which was considered due to Meeds-io/si#3 issue. This change will avoid using such control explicitly on 'AboutMe' and 'Experiences' field since it's displayed in dedicated sections in the profile page of the user, and thus will be displayed all time for all users when not empty.At the same time, the field
genderisn't retrieved automatically in Profile REST calls since it's deprecated functionally.Resolves Meeds-io/meeds#2577