fix: [BUG] Invitation to join space : notification is never updated - EXO-75048 - Meeds-io/meeds#2531 #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- Meeds-io/meeds#1952 . (#3767) Before this change, when display profile attributes and change filter to display all or disabled attributes, enabled attributes are always displayed.After this change, display is related to chosen filter.
…aces portlet - EXO-61391 - Meeds-io/meeds#1828 (#3826) Prior to this change, The External Spaces displays 40 spaces (spaces where user is member and spaces where user is invited) at maximum and are sorted by default in alphabetical order. This creates a bad display and adds white space in the other widgets of snapshot page, The fix change this behaviour to show only 10 spaces by default and only spaces where user is member and add a load more botton to show more spaces if exists.
…- Meeds-io/meeds#1952 . (#3767) Before this change, when display profile attributes and change filter to display all or disabled attributes, enabled attributes are always displayed.After this change, display is related to chosen filter.
…aces portlet - EXO-61391 - Meeds-io/meeds#1828 (#3826) Prior to this change, The External Spaces displays 40 spaces (spaces where user is member and spaces where user is invited) at maximum and are sorted by default in alphabetical order. This creates a bad display and adds white space in the other widgets of snapshot page, The fix change this behaviour to show only 10 spaces by default and only spaces where user is member and add a load more botton to show more spaces if exists.
…XO-75048 - Meeds-io/meeds#2531 Prior to this change, if a user is invited to join a space, and he accepts, the join notification is never updated. This commit fix this bug by correcting the update notification method since the condition to check if the notification should be updated or not was wrong.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if a user is invited to join a space, and he accepts, the join notification is never updated.
This commit fix this bug by correcting the update notification method since the condition to check if the notification should be updated or not was wrong.