Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sweep issue using AR language in cardCarrousel component - EXO-74720 -Meeds-io/meeds#2530. #4135

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

akhanfir
Copy link
Contributor

Before this change, when choose Arabic language (RTL mode) and create spaceX and add news stories template dislaying more than 10 news articles then publish several news articles in spacesX news target and sweep published news (in Stories template) from left to right, reaching the news limit on the right, the left back arrow does not appear as in LTR mode. To resolve this problem, in RTL mode, reverse the roles and display between the right and left scroll buttons compared to LTR mode. After this change, the back arrow from the two sides displays correctly and they sweep articles.

…4720 -Meeds-io/meeds#2530.

Before this change, when choose Arabic language (RTL mode) and create spaceX and add news stories template dislaying more than 10 news articles then publish several news articles in spacesX news target and sweep published news (in Stories template) from left to right, reaching the news limit on the right, the left back arrow does not appear as in LTR mode. To resolve this problem, in RTL mode, reverse the roles and display between the right and left scroll buttons compared to LTR mode. After this change, the back arrow from the two sides displays correctly and they sweep articles.
@akhanfir akhanfir requested a review from mkrout October 28, 2024 08:16
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Oct 28, 2024
Copy link

sonarcloud bot commented Oct 28, 2024

@akhanfir akhanfir merged commit 6eb3942 into feature/maintenance Oct 28, 2024
6 checks passed
@akhanfir akhanfir deleted the TASK-74720 branch October 28, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants