feat: Display the activity views count - EXO-74854 - Meeds-io/MIPs#161 #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofyenne
changed the title
exo-swf
force-pushed
the
feature/experience
branch
from
1723066
to
fa94163
Compare
azayati
requested changes
Oct 23, 2024
| @@ -122,6 +122,19 @@ | |||
| @click="displayFullContent"> | |||
| <span class="pl-6">{{ $t('UIActivity.label.seeMore') }}</span> | |||
| </v-btn> | |||
| <div | |||
| v-if="activityViews" | |||
| :title="activityViewsTooltip" | |||
There was a problem hiding this comment.
it should be v-tooltip instead IMO as it is done in news detail
There was a problem hiding this comment.
To follow the guidelines, we use the same navigator tooltip as the activity link title and summary, as confirmed by the PO!
azayati
requested changes
Oct 23, 2024
|
done! |
exo-swf
pushed a commit
that referenced
this pull request
Oct 23, 2024
exo-swf
pushed a commit
that referenced
this pull request
Oct 24, 2024
exo-swf
pushed a commit
that referenced
this pull request
Oct 25, 2024
exo-swf
pushed a commit
that referenced
this pull request
Oct 29, 2024
sofyenne
added a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.