fix: Unsearchable disabled users by their email or name-EXO-69348-Meeds-io/meeds#1827 #4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds-io/meeds#1827. Before this change, when create usera with a First name different than his login, set usera as a disabled user, select disabled filter and search for usera by his name or his email, usera isn't displayed in the result list.To resolve this problem, in the inputUserFilter component we make a condition to display the component only if the filter is enabled.After this change, Hide filter by name or email field when disabled users list displayed on user management application. (cherry picked from commit 0711574)
akhanfir
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when create user with a First name different than his login, set user as a disabled user, select disabled filter and search for user by his name or his email, user isn't displayed in the result list.
To resolve this problem, we make a condition in the inputUserFilter component to display the component only if the filter is enabled.
After this change, Hide filter by name or email field when disabled users list displayed on user management application.