Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: introduce error codes #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

javereec
Copy link
Contributor

@javereec javereec commented Feb 9, 2024

Just an idea I had to improve how errors can be extended with codes allowing for better handling by clients.

I think it also fixes some other issues in the specs

@vijayshiyani
Copy link
Contributor

Good idea, I changed how error messages structure.
TO DO:

  • Fix error messages
  • Fix tests

@linasi
Copy link
Collaborator

linasi commented Feb 13, 2024

Looks good. I would suggest to keep it a bit more simple.

  • extra_info related functionality should be dropped
  • remove getResponse method, error message is available via error.message that comes form the base class.
  • remove equals method

I am not so sure about having code and errorType attributes together. They seem to overlap a little. Are there any rules on how they are defined? Wouldn't just having one be enough? Also, shouldn't code be a unique value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants