Add PSA Crypto driver delegation for hashing functions #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes basic test. Based on the design document in psa-driver-interface.md. Signed-off-by: Steven Cooreman <[email protected]>
Signed-off-by: Steven Cooreman <[email protected]>
gabor-mezei-arm
added
Community
component-psa
Signed-off-by: Steven Cooreman <[email protected]>
ronald-cron-arm
requested changes
Jan 22, 2021
| @@ -2607,6 +2624,17 @@ psa_status_t psa_hash_setup( psa_hash_operation_t *operation, | |||
| return( PSA_ERROR_BAD_STATE ); | |||
| } | |||
|
|
|||
| operation->mbedtls_in_use = 0; | |||
There was a problem hiding this comment.
This is not aligned with the organization of the PSA implementation with respect to the PSA driver interface that we are currently trying to move to. The code organization is described in the psa-crypto-implementation-structure.md document in PR #3933 and an example of its application for multi-part operation can be found here (for ciphers).
Thus this is likely that this PR will need some significant refactoring. It is also probably better to not start any refactoring before PR #3933 is merged.
ronald-cron-arm
added
needs-work
and removed
needs-reviewer
ronald-cron-arm
removed
the
needs-review
|
Superseded by #4157 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add driver delegation as per the already established paradigms and the design document in
docs/proposed/psa-driver-interface.md.Status
READY
Requires Backporting
NO
Migrations
NO
Additional comments
Todos
Steps to test or reproduce
Test coverage through
test_psa_crypto_drivers, which compiles with driver support and the test driver.test_suite_psa_crypto_driver_wrappers