Cart #5
Open
Cart #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+7
to
+8
|
|
||
| useEffect(() => {}); |
There was a problem hiding this comment.
Empty useEffect? Not sure if you intend to use it later
Comment on lines
+29
to
+30
| src={product.img} | ||
| alt="" |
There was a problem hiding this comment.
Suggestion : Give a value for alt attribute
There was a problem hiding this comment.
Okay, I'll do the suggested changes Thank you Balaji for PR Review
BalajiHarinath
approved these changes
Mar 31, 2022
yash9263
approved these changes
Mar 31, 2022
|
Everything looks good. code indentation is a little bit more that can be improved. |
Okay, I'll do that Thank you Yashwant for PR Review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Cart