Landing page #2
Landing page #2
Conversation
| ForgotPassword, | ||
| UserPage, | ||
| WishList, | ||
| } from "./components/index"; |
There was a problem hiding this comment.
you can just import from ./components, that /index can be skipped.
There was a problem hiding this comment.
Okay, I'll do that.
src/components/Home/HomePage.jsx
Outdated
| src="../images/img2.webp" | ||
| width="900" | ||
| height="700" | ||
| alt="" |
There was a problem hiding this comment.
try to give alt attribute some description about the image..
There was a problem hiding this comment.
For performance basis. You can add --- loading="lazy"------ to img tag. It will help in optimization .
There was a problem hiding this comment.
Okay, I'll do that.
src/components/Home/HomePage.jsx
Outdated
| <div className="mid-card-container sm-card-shadow padding-normal flex-row-center AlertError imgTransition"> | ||
| <section className="flex-row-start"> | ||
| <img | ||
| className="margin-0 cart-img" | ||
| src="../images/pc-svg-1.svg" | ||
| alt="" | ||
| /> | ||
| </section> | ||
|
|
There was a problem hiding this comment.
instead of creating card again, you can loop through the card data more for code readability.
There was a problem hiding this comment.
Okay, I'll do that. Thank's Neha For PR review
src/components/Home/HomePage.jsx
Outdated
| src="../images/img2.webp" | ||
| width="900" | ||
| height="700" | ||
| alt="" |
There was a problem hiding this comment.
For performance basis. You can add --- loading="lazy"------ to img tag. It will help in optimization .
src/components/Home/HomePage.jsx
Outdated
| <span | ||
| className="card-container card-box cardBadge box-shadow" | ||
| data-label="Trending" | ||
| > | ||
| <section className="img-card-offer padding-normal"> | ||
| <img | ||
| className="imgcard" | ||
| src="../images/pc-svg-1.svg" | ||
| alt="" | ||
| /> | ||
| <button className="material-icons-text card-wishlist-icons buttonHoverShadow AvatarImage AvatarIcons flex-row-center icon-wishlist"> | ||
| <i className="material-icons"> | ||
| favorite | ||
| </i> | ||
| </button> | ||
| </section> | ||
|
|
There was a problem hiding this comment.
You can make card component. And use that by using map function
There was a problem hiding this comment.
Okay, I'll do that. Thank's Vishal for PR review
Adding Header Footer and assets