Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial-commit adding Header, footer and assets #1

Open
wants to merge 2 commits into
base: Main
Choose a base branch
from
Open

Initial-commit adding Header, footer and assets #1

wants to merge 2 commits into from

Conversation

MayankKumar10
Copy link
Owner

Adding Header Footer and assets

foolhardy21
foolhardy21 approved these changes Mar 29, 2022
View reviewed changes
Copy link

@foolhardy21 foolhardy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good use of semantic html. suggestions - add alt for phoenix ui.jpg in Header.jsx and you may reduce indentation gap for readability.

VLeads
VLeads approved these changes Mar 29, 2022
View reviewed changes
Copy link

@VLeads VLeads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gode work till now. A little indentation can be fixed !!

@MayankKumar10
Copy link
Owner Author

Gode work till now. A little indentation can be fixed !!

Okay, I'll change it.

@MayankKumar10
Copy link
Owner Author

good use of semantic html. suggestions - add alt for phoenix ui.jpg in Header.jsx and you may reduce indentation gap for readability.

I'll do that. Thank's Vinay for PR review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolhardy21 foolhardy21 foolhardy21 approved these changes

@VLeads VLeads VLeads approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MayankKumar10 @VLeads @foolhardy21