Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Vite Migration (#204)" #208

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Reapply "Vite Migration (#204)" #208

merged 3 commits into from
Sep 10, 2024

Conversation

MaxwellBo
Copy link
Owner

@MaxwellBo MaxwellBo commented Sep 6, 2024

This reverts commit e703bc3.

I think there's something funky going on with resolving routes on non / URL paths. Hopefully the bug exposes itself in the Netlify branch deploy preview because the bug isn't visible when run locally.

#207

@MaxwellBo MaxwellBo requested a review from GeordieEK September 6, 2024 22:08
@MaxwellBo
Copy link
Owner Author

Yeah odd

image

Resolving manifest from non-root.

@MaxwellBo MaxwellBo force-pushed the mjbo-revert-revert-vite branch from 00daada to 795ea42 Compare September 10, 2024 09:25
@MaxwellBo MaxwellBo merged commit d145bf3 into master Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants