Improve the create account onboarding flow

[MaxwellBo]

After

Before

[cypress]

---

Test summary

18 • 0 • 0 • 0

---

Run details

Project	Muncoordinated
Status	Passed
Commit	10a1a69
Started	Jan 12, 2021 6:20 AM
Ended	Jan 12, 2021 6:22 AM
Duration	02:03 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Electron 73

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[MaxwellBo]

@kumar-ish fiddle around with this and see if it feels nice. I'm not sure if moving the 'Create account' button to a seperate step is a good thing.

On the one hand, it feels more inline with what people expect, and will allow us to ask questions when accounts are created like display name or marketing consent.

On the other hand, it will slow onboarding down by adding an extra click.

This PR is a good springboard for #105 and #85

[MaxwellBo]

Resolved: Fix breaking Cypress tests CypressError: Timed out retrying: Expected to find content: 'Log in' within the element: [ <button.ui.button.nav__auth-status>, 1 more... ] but never did.

[kumar-ish]

It looks a lot nicer, and feels more intuitive to me; at least this way account creation/login are somewhat separated too. LGTM

I tried amending it without a hacky pixel fix, but we still have to fix this floaty-ass cursed button somehow (and I think it might be beyond my ability to do so):

[MaxwellBo]

I tried amending it without a hacky pixel fix, but we still have to fix this floaty-ass cursed button somehow (and I think it might be beyond my ability to do so):

Yeah, I tried fiddling around with it myself and it seems a little nightmarish :( I considered dropping it entirely and just flat out merging template creation into the setup screen, but I worry that that might negate the whole "oh cool it has committee templates" effect that you immediately see when you start to onboard .