add formAdmin struct #4
Conversation
contracts/evoting/json/adminForm.go
Outdated
| return nil, xerrors.Errorf("failed to marshal form: %v", err) | ||
| } | ||
|
|
||
| return buff, nil |
There was a problem hiding this comment.
I take it the idea behind the switch statement is to add other formats at a later point?
There was a problem hiding this comment.
I just took the same coding style/convention of the equivalent file for the "classic" form: https://github.com/MaximeZmt/d-voting/blob/main/contracts/evoting/json/forms.go
Should I change it ?
There was a problem hiding this comment.
if there's only one format the switch logic seems to be a bit superfluous to me, especially as you're not doing it in the Decode function - I'd just do something like this:
func (adminFormFormat) Encode(ctx serde.Context, message serde.Message) ([]byte, error) {
if message.(type) != types.AdminForm {
return nil, xerrors.Errorf("Unknown format: %T", message)
}
<rest of the function>
}
like this it returns immediately if it's not the correct type (no need for an else which makes it more readable), and the logic is simpler (makes it easier to understand)
switch makes only sense if there's multiple cases
edit .gitignore to add new line at the end as before
| return buff, nil | ||
| default: | ||
| adminForm, ok := message.(types.AdminForm) | ||
| if !ok { |
There was a problem hiding this comment.
if there is no error it is the correct format?
Thank you for opening a pull request with this project, please also:
draftmode andin progresspipeline in the project (if applicable)RevieworReady4Mergepipeline in the project (if applicable)draft