Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotate #501

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix rotate #501

wants to merge 8 commits into from

Conversation

pebri86
Copy link

@pebri86 pebri86 commented Dec 20, 2024

Description of the changes

This PR to address some issue with appearance of signature when page is rotated

Caveats

Basically this PR is fixing work previously by DominikDostal PR #266
Also should fix some other issue #312 #265

Honestly I don't know if my work can be accepted, but let me know what should i do

Thank you

Checklist

Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

  • I have read the project's CoC and contribution guidelines.
  • I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
  • All new code in this PR has full test coverage.

For bug fixes (delete if not applicable)

  • My changes do not affect any public API or CLI semantics.
  • My PR adds regression tests (i.e. tests that fail if the bug fix is not applied).
  • All new code in this PR has full test coverage.

Additional comments

Feel free to add any additional comments here.

@MatthiasValvekens
Copy link
Owner

MatthiasValvekens commented Dec 20, 2024

Hi, thanks for your contribution.

Before we proceed: can you please revert the formatting changes and reapply them using the same settings as used in the project's lint job? Essentially it's Black with a line length limit of 80 characters and quotes preserved.

That should reduce the noise in the diff somewhat.

@pebri86
Copy link
Author

pebri86 commented Dec 21, 2024

Hi, thanks for your contribution.

Before we proceed: can you please revert the formatting changes and reapply them using the same settings as used in the project's lint job? Essentially it's Black with a line length limit of 80 characters and quotes preserved.

That should reduce the noise in the diff somewhat.

Thank you for replying, okay sorry, I didn't really pay attention if now black changes the default quote to double. I've finished formatting, hopefully it's cleaner for reviewing changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants