Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate AcroForms without a Fields entry #404

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

MatthiasValvekens
Copy link
Owner

Description of the changes

Tolerate AcroForm dictionaries that don't contain a Fields entry when making changes to a PDF. We'll create it on the fly if needed, even though the input document would strictly speaking not be valid.

Fixes #403.

Checklist

Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

  • I have read the project's CoC and contribution guidelines.
  • I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
  • All new code in this PR has full test coverage.

For bug fixes (delete if not applicable)

  • My changes do not affect any public API or CLI semantics.
  • My PR adds regression tests (i.e. tests that fail if the bug fix is not applied).
  • All new code in this PR has full test coverage.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (5a9d8eb) to head (6d4cde9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         113      113           
  Lines       16265    16265           
=======================================
  Hits        16075    16075           
  Misses        190      190           
Flag Coverage Δ
unittests 98.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthiasValvekens MatthiasValvekens merged commit 8e870e6 into master Mar 22, 2024
21 checks passed
@MatthiasValvekens MatthiasValvekens deleted the bugfix/allow-acroform-without-fields branch April 27, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF signing breaks if no fields object in Acroform
3 participants