Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in looking up PKCS#11 objects #395

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

MatthiasValvekens
Copy link
Owner

Description of the changes

Some config fallbacks in the PKCS#11 setup were a little too aggressive, leading to overly specific lookups in some cases.

Fixes #394.

Caveats

None

Checklist

Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

  • I have read the project's CoC and contribution guidelines.
  • I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
  • All new code in this PR has full test coverage.

For bug fixes (delete if not applicable)

  • My changes do not affect any public API or CLI semantics.
  • My PR adds regression tests (i.e. tests that fail if the bug fix is not applied).
  • All new code in this PR has full test coverage.

Some config fallbacks were a little too aggressive.

Fixes #394.
@MatthiasValvekens MatthiasValvekens merged commit 44467ef into master Mar 14, 2024
21 checks passed
@MatthiasValvekens MatthiasValvekens deleted the bugfix/pkcs11-lookup-regression branch March 14, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hardware token pkcs11.exceptions.NoSuchKey after upgrading to 0.23.0
1 participant