Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated line and improve naming consistency #367

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

dspinellis
Copy link
Contributor

  • The line psi = tbs_document.post_sign_instructions needlessly appeared twice in the code.

  • The first part's output variable is used as output_handle in the second part. Make both names consistent.

Description of the changes

Small documentation fix in the interrupted signing example code.

Checklist

Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

  • I have read the project's CoC and contribution guidelines.
  • I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
  • All new code in this PR has full test coverage.

For documentation contributions (delete if not applicable)

  • I have built the HTML documentation locally, and verified that the changes behave correctly in-browser.

* The line `psi = tbs_document.post_sign_instructions` needlessly appeared twice in the code.

* The first part's `output` variable is used as `output_handle` in the second part. Make both names consistent.
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7aef45a) 98.83% compared to head (df95c0b) 98.83%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         113      113           
  Lines       16289    16289           
=======================================
  Hits        16099    16099           
  Misses        190      190           
Flag Coverage Δ
unittests 98.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthiasValvekens
Copy link
Owner

MatthiasValvekens commented Jan 30, 2024

Thanks; will merge this.

(EDIT: I fixed the CI issue that was causing your build to fail in the meantime)

@MatthiasValvekens MatthiasValvekens merged commit 32ca9ec into MatthiasValvekens:master Jan 30, 2024
18 of 19 checks passed
@dspinellis
Copy link
Contributor Author

Thank you for the merge, and thank you even more for pyHanko! With it I wrote a tool to sign PDFs using a remote signature API in just a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants