Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature's dictionary entries on API (/ContactInfo, /Prop_AuthTime and /Prop_AuthType) #314

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

eduperottoni
Copy link
Contributor

@eduperottoni eduperottoni commented Sep 1, 2023

Description of the changes

This PR adds some options that high level API doesn't support regarding to signature's dictionary entries. More specifically, adds support to coverage of the following signature entries, described in ISO-32000: /ContactInfo, /Prop_AuthTime and /Prop_AuthType.

Related to #307.

@MatthiasValvekens MatthiasValvekens self-requested a review September 1, 2023 05:48
@MatthiasValvekens MatthiasValvekens self-assigned this Sep 1, 2023
Copy link
Owner

@MatthiasValvekens MatthiasValvekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! A few minor issues, but they should be all easy to address (and I'm open to discussion on some of them).

I'll also go ahead and let the CI work through your changes.

pyhanko/cli/commands/signing/__init__.py Show resolved Hide resolved
pyhanko/cli/commands/signing/__init__.py Show resolved Hide resolved
pyhanko/sign/fields.py Outdated Show resolved Hide resolved
pyhanko/sign/signers/pdf_signer.py Outdated Show resolved Hide resolved
@MatthiasValvekens
Copy link
Owner

@eduperottoni Please also make the linter happy with isort --profile black --line-length 80 pyhanko pyhanko_tests and black -q -S --line-length 80 pyhanko pyhanko_tests

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc3d7d2) 98.76% compared to head (f258829) 98.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files         104      104           
  Lines       14712    14730   +18     
=======================================
+ Hits        14530    14548   +18     
  Misses        182      182           
Flag Coverage Δ
unittests 98.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pyhanko/cli/commands/signing/__init__.py 98.79% <100.00%> (+0.01%) ⬆️
pyhanko/sign/fields.py 99.37% <100.00%> (+<0.01%) ⬆️
pyhanko/sign/signers/pdf_byterange.py 100.00% <100.00%> (ø)
pyhanko/sign/signers/pdf_signer.py 99.84% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@MatthiasValvekens MatthiasValvekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatthiasValvekens MatthiasValvekens merged commit 5e3f35f into MatthiasValvekens:master Sep 25, 2023
19 checks passed
@MatthiasValvekens
Copy link
Owner

Rebased & merged; thanks for your contribution!

@eduperottoni
Copy link
Contributor Author

eduperottoni commented Sep 25, 2023

Thank you for your review and for all the job on pyHanko, @MatthiasValvekens!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants