-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signature's dictionary entries on API (/ContactInfo, /Prop_AuthTime and /Prop_AuthType) #314
Add signature's dictionary entries on API (/ContactInfo, /Prop_AuthTime and /Prop_AuthType) #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! A few minor issues, but they should be all easy to address (and I'm open to discussion on some of them).
I'll also go ahead and let the CI work through your changes.
@eduperottoni Please also make the linter happy with |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 104 104
Lines 14712 14730 +18
=======================================
+ Hits 14530 14548 +18
Misses 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3d777a3
to
f258829
Compare
Rebased & merged; thanks for your contribution! |
Thank you for your review and for all the job on pyHanko, @MatthiasValvekens! |
Description of the changes
This PR adds some options that high level API doesn't support regarding to signature's dictionary entries. More specifically, adds support to coverage of the following signature entries, described in ISO-32000:
/ContactInfo
,/Prop_AuthTime
and/Prop_AuthType
.Related to #307.