final cleanup before PR. deletes newman files.

Matte22 · Sep 24, 2024 · 3aecdc7 · 3aecdc7
1 parent 0ae75c5
commit 3aecdc7
Show file tree

Hide file tree

Showing 20 changed files with 82 additions and 74,525 deletions.
diff --git a/test/api/collectionRunnerData.json b/test/api/collectionRunnerData.json
diff --git a/test/api/customReporter.js b/test/api/customReporter.js
diff --git a/test/api/mocha/data/asset/assetPatch.test.js b/test/api/mocha/data/asset/assetPatch.test.js
@@ -82,8 +82,8 @@ describe('PATCH - Asset', function () {
           }
           expect(res).to.have.status(200)
           expect(res.body.collection.collectionId).to.equal(reference.scrapCollection.collectionId)
-          expect(res.body.labelIds).to.have.lengthOf(2)
-          expect(res.body.ip).to.equal("1.1.1.1")
+          expect(res.body.labelIds).to.have.lengthOf(reference.testAsset.labels.length)
+          expect(res.body.ip).to.equal(reference.testAsset.ipaddress)
           expect(res.body.noncomputing).to.equal(true)
           expect(res.body.metadata).to.deep.equal({})
           expect(res.body.description).to.equal('test desc')
@@ -256,7 +256,7 @@ describe('PATCH - Asset', function () {
 
             for(const assetID of res.body.assetIds){
                 const effectedAsset = await utils.getAsset(assetID)
-                expect(effectedAsset.response, "response should be 403 due to asset being deleted").to.have.status(403)
+                expect(effectedAsset.status, "response should be 403 due to asset being deleted").to.equal(403)
             }
 
         })

diff --git a/test/api/mocha/data/collection/collectionDelete.test.js b/test/api/mocha/data/collection/collectionDelete.test.js
@@ -36,7 +36,6 @@ describe('DELETE - Collection ', function () {
           const testCollectionClone  = JSON.parse(JSON.stringify(requestBodies.resetTestCollection))
           testCollectionClone.name = `Collection ` + Math.floor(Math.random() * 1000000)
           tempCollection = await utils.createTempCollection(testCollectionClone)
-          console.log(`tempCollection: ${tempCollection.data.collectionId}`)
         })
 
         it('Delete tempCollection collection (stigmanadmin only)',async function () {
@@ -54,7 +53,7 @@ describe('DELETE - Collection ', function () {
 
           //confirm that it is deleted
           const deletedCollection = await utils.getCollection(tempCollection.data.collectionId)
-          expect(deletedCollection).to.be.undefined
+          expect(deletedCollection.status, "expect 403 response (delete worked)").to.equal(403)
         })
 
       })

diff --git a/test/api/mocha/data/collection/collectionGet.test.js b/test/api/mocha/data/collection/collectionGet.test.js
@@ -266,6 +266,7 @@ describe('GET - Collection', function () {
         })
       })
 
+      // needs some projection work
       describe('getFindingsByCollection - /collections/{collectionId}/findings', function () {
 
         it('Return the Findings for the specified Collection by ruleId',async function () {
-Original file line number
+Diff line change
@@ Expand Up / @@ -266,6 +266,7 @@ describe('GET - Collection', function () { @@
             })
           })
+          // needs some projection work
           describe('getFindingsByCollection - /collections/{collectionId}/findings', function () {
             it('Return the Findings for the specified Collection by ruleId',async function () {
@@ Expand Down @@