Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] update the semantic files based on RFC 9559 #209

Merged
merged 4 commits into from
Jan 26, 2025
Merged

[1.x] update the semantic files based on RFC 9559 #209

merged 4 commits into from
Jan 26, 2025
+37 −45

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jan 5, 2025

The API-break is only for the enum values that neither mkvtoolnix nor VLC use:

  • MATROSKA_VIDEO_FIELDORDER_TOPFIELDSWAPPED/MATROSKA_VIDEO_FIELDORDER_BOTTOMFIELDSWAPPED values are swapped
  • MATROSKA_CHAPTERTRANSLATECODEC_xxx are gone
  • MATROSKA_TRACKTRANSLATECODEC_xxx are gone
  • MATROSKA_CHAPPROCESSCODECID_xxx are added

@robUx4 robUx4 added the api-break breaks the API (e.g. programs using it will have to adjust their source code) label Jan 5, 2025
@robUx4 robUx4 requested a review from mbunkus January 5, 2025 08:40
@robUx4 robUx4 force-pushed the 1x-semantic-rfc9559 branch from 19c27d7 to 4b93f52 Compare January 5, 2025 08:57
mbunkus
mbunkus requested changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@mbunkus mbunkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please re-do the PR without the changes to the github workflows? Thanks.

@robUx4
Copy link
Contributor Author

robUx4 commented Jan 26, 2025

Can you please re-do the PR without the changes to the github workflows? Thanks.

Ooops

@robUx4 robUx4 force-pushed the 1x-semantic-rfc9559 branch 3 times, most recently from dc0bd0d to caffd96 Compare January 26, 2025 06:05
@robUx4 robUx4 force-pushed the 1x-semantic-rfc9559 branch from caffd96 to 8dff6b0 Compare January 26, 2025 06:06
@robUx4 robUx4 requested a review from mbunkus January 26, 2025 06:08
@mbunkus mbunkus merged commit f163fc1 into Matroska-Org:v1.x Jan 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus