-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing random CI failures due to message skips #74
Conversation
I removed a couple tests from the files as they were redundant and literally duplicating code. Some others, I feel like they might be redundant. I will be going through the changes in-depth tomorrow and make a brief list discussing the reasoning behind the test removals. Also, the formatting, while correct, was too verbose. I re-formatted the code, which is the main culprit in adding a lot of lines changed in this commit. However, in conclusion, basically everything is working at this point, and the weird stream plumbing has been replaced with a more elegant solution as a special transform stream which returns the JSON header message after parsing and returns the following as raw bytes without applying any processing on it. The CI for this change is passing, both locally and on github. The only way to see if the change is actually made and is consistent is to merge it to staging and see whether the CI breaks or not. Also, @brynblack still needs to set up auto deployment for this repo. Maybe after I have merged this PR and (hopefully) fixed the CI, you can merge a quick fix for that. |
This is a blocker, please address this asap @brynblack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need some general inputs on some things.
chore: fixed ci and updated all tests chore: cleaned up code chore: moved common function out
156278d
to
769d66f
Compare
Did this change any expected behaviour at the UI level? |
No, there was no external change to using the streams in any way. This PR just changed internal code related to retrieval of the header message to use a more elegant system instead of replumbing streams. |
Description
This PR focuses on resolving #70, which is a critical bug that happens in the CI because the second message is skipped.
Issues Fixed
Tasks
Final checklist