Implementing secrets rm RPC handler
#803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
aryanjassal
force-pushed
the
feature-unix-rm
branch
from
77ed38a to
02e3049
Compare
tegefaulkes
requested changes
Sep 10, 2024
tegefaulkes
approved these changes
Sep 10, 2024
|
Looking good now. Prep it for merge but I wouldn't merge it until the CLI side is done and ready to merge as well. |
aryanjassal
force-pushed
the
feature-unix-rm
branch
2 times, most recently
from
ae52289 to
04f0df0
Compare
|
Even when removing a secret, it will exist in the vault history which can be checked out. |
Yes, I believe this is correct. Do I need to remove the file from vault history too? If the user has access to a secret, they can always just copy the secret and back it up somewhere else, so removing the file from vault history doesn't make much sense to me. |
|
No.
|
aryanjassal
force-pushed
the
feature-unix-rm
branch
from
c326834 to
b9bf86a
Compare
feat: deleted old secrets delete handlers feat: added tests feat: performed requested changes chore: added more tests for vaultOps.deleteSecret chore: handles removing secrets of multiple vaults chore: added tests for deleting multiple secrets
aryanjassal
force-pushed
the
feature-unix-rm
branch
from
b9bf86a to
f0ae66b
Compare
|
Everything for this PR has been done and approved. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a RPC handler to delete multiple files. If an option is set, then also delete the specified directory and the contents of that directory from the vaults.
Issues Fixed
secrets rmcommand Polykey-CLI#247 (ENG-360)Tasks
VaultsSecretsRemovehandler (functionally similar toVaultsSecretsDelete)Final checklist