Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: making nixpkgs-matrix an indirect input #802

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Sep 2, 2024

Description

This PR incorporates the new indirect flake input system.

Tasks

  • 1. Update flake.nix to use indirect inputs

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Sep 2, 2024
@tegefaulkes
Copy link
Contributor Author

I'm doing this as a PR here for reference and just so that @brynblack can check I got the change right.

@tegefaulkes
Copy link
Contributor Author

Ah, I can't seem to find nixpkgs-matrix in the flake registries. I possibly have to do a nix rebuild to get that into my profile right?

@tegefaulkes
Copy link
Contributor Author

Ok, I only had to add it to the registry with nix registry add nixpkgs-matrix github:MatrixAI/nixpkgs-matrix.

@brynblack
Copy link
Member

This looks good. I think it can be merged once we have all our other repos ready for the transition.

Copy link
Member

@brynblack brynblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to change. Maybe add some documentation to the README.md.

@brynblack brynblack force-pushed the feature-indirect-flakes branch 2 times, most recently from 724b32e to fd5713c Compare September 6, 2024 01:46
@brynblack brynblack self-assigned this Sep 6, 2024
@brynblack brynblack requested review from brynblack and removed request for brynblack September 6, 2024 01:47
@brynblack brynblack force-pushed the feature-indirect-flakes branch from fd5713c to 9499681 Compare September 15, 2024 22:43
@brynblack brynblack force-pushed the feature-indirect-flakes branch from 9499681 to 1ffb66f Compare September 18, 2024 03:44
@brynblack brynblack merged commit c70c147 into staging Sep 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants