-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node 20 #137
Upgrade to Node 20 #137
Conversation
18000be
to
1e44d37
Compare
The problem with the jest tests is:
We need a workaround for dealing with |
56a915a
to
ffb5da4
Compare
fix: reset `flake.nix` pin to older version
ffb5da4
to
13bdba8
Compare
ci: added darwin arm64 as `nix build` target
13bdba8
to
654208d
Compare
The workaround I have opted, is to docblock An alternative solution could be to just set the exitCode to zero at the end of |
Did you make sure to indicate in that docblock that the reason for this workaround is solely due a jest bug, and link the jest bug itself when it gets resolved? |
Not sure if that would work, after all isn't it the internal command that is executed that does it? |
@amydevs @tegefaulkes you must remember to set the assignments - otherwise these won't be tracked later in R&D. |
Description
This PR upgrades the Node version for all development environments to Node 20, and enables building of arm64 macos builds.
Issues Fixed
pkg
#111Tasks
utils.nix
node package tonodejs_20
for buildspflake.nix
mkShell
inputs node package tonodejs_20
fornix develop
environmentsscripts/choco-install.ps1
to usenodev20.5.1
scripts/brew-install.sh
to usenode@20
..gitlab-ci.yml
utils.pkStdio
to warn usage when the expectedprocess.exitCode
is non-zero.Final checklist