feat: secrets env now uses single -- to separate commands

fix: updated tests chore: removed redundant tests
MatrixAI · Nov 21, 2024 · 58f4752 · 58f4752
1 parent 73e25d8
commit 58f4752
Show file tree

Hide file tree

Showing 6 changed files with 294 additions and 344 deletions.
diff --git a/src/errors.ts b/src/errors.ts
@@ -84,8 +84,8 @@ class ErrorPolykeyCLIUnexpectedError<T> extends ErrorPolykeyCLI<T> {
   exitCode = sysexits.SOFTWARE;
 }
 
-class ErrorPolykeyCLISubprocessFailure<T> extends ErrorPolykeyCLI<T> {
-  static description = 'A subprocess failed to exit gracefully';
+class ErrorPolykeyCLIChildProcessFailure<T> extends ErrorPolykeyCLI<T> {
+  static description = 'A child process failed to exit gracefully';
   exitCode = sysexits.UNKNOWN;
 }
 
@@ -196,7 +196,7 @@ export {
   ErrorPolykeyCLIUncaughtException,
   ErrorPolykeyCLIUnhandledRejection,
   ErrorPolykeyCLIUnexpectedError,
-  ErrorPolykeyCLISubprocessFailure,
+  ErrorPolykeyCLIChildProcessFailure,
   ErrorPolykeyCLIAsynchronousDeadlock,
   ErrorPolykeyCLINodePath,
   ErrorPolykeyCLIClientOptions,

diff --git a/src/secrets/CommandEdit.ts b/src/secrets/CommandEdit.ts
@@ -120,7 +120,7 @@ class CommandEdit extends CommandPolykey {
           };
           const onError = (e: Error) => {
             cleanup();
-            const error = new errors.ErrorPolykeyCLISubprocessFailure(
+            const error = new errors.ErrorPolykeyCLIChildProcessFailure(
               `Failed to run command '${process.env.EDITOR}'`,
               { cause: e },
             );
@@ -129,7 +129,7 @@ class CommandEdit extends CommandPolykey {
           const onClose = (code: number | null) => {
             cleanup();
             if (code !== 0) {
-              const error = new errors.ErrorPolykeyCLISubprocessFailure(
+              const error = new errors.ErrorPolykeyCLIChildProcessFailure(
                 `Editor exited with code ${code}`,
               );
               reject(error);