Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for Range #952

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Add description for Range #952

merged 4 commits into from
Jan 17, 2024

Conversation

Li-Xiang-Ideal
Copy link
Contributor

No description provided.

@@ -213,6 +213,12 @@ class Range(Builtin):

<dt>'Range[$a$, $b$]'
<dd>returns a list of integers from $a$ to $b$.

<dt>'Range[$a$, $b$, $di$]'
<dd>returns a list of integers from $a$ to $b$ using step $di$.
Copy link

@axkr axkr Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only integers but appropriate values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion. Do you think the current one is better, or simply returns a list of numbers from $a$ to $b$.?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only numbers if you see this example:

Together can help to simplify the expressions generated by the iterator to real values:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, Range in Mathics3 only accepts real arguments for now. For some historical reason it does not use the same implementation as Table, which makes it more efficient while having more limited applicability.

Anyway, your suggestion sounds good and I think it's worth considering in our future reorganization of historical codes including Range. Would you mind putting your suggestions to Issues? That way we can remember it after this PR is closed (which could be soon since I don't have time to rewrite Range in this PR for now).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can better add details in an issue, how to use the Table iterator implementation for Range.

@rocky
Copy link
Member

rocky commented Jan 17, 2024

This change is a correction and improvement as is. Please feel free to open issues or features in the issue/feature part of github.

@rocky rocky merged commit 8a5a691 into master Jan 17, 2024
11 checks passed
@rocky rocky deleted the fix-range branch January 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants