Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatValues #1303

Merged
merged 2 commits into from
Jan 19, 2025
Merged

FormatValues #1303

merged 2 commits into from
Jan 19, 2025

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Jan 18, 2025

This PR adds FormatValues to access the format values of Symbols.

# In Mathematica 5, this appears under "Types of Values".
class FormatValues(Builtin):
"""
<url>:WMA link: https://reference.wolfram.com/language/ref/FormatValues.html</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nonexistent link.

I am curious why there is interest in this right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I was running some experiments which work on WMA, and not here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But please let's defer Boxing and Formatting work until after release. I am having problems with the amount of work needed to go over for the current release. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are looking for something to do that will assist with the next release remember when you wrote #1290 (comment) :

Mathics-Django uses Mathjax to render equations, so it is just a matter to call the render when the documentation is loaded. I will look how to do this later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this symbol remains undocumented since WMA v3...
https://reference.wolfram.com/legacy/v3/MainBook/A.5.3.html

Copy link
Member

@rocky rocky Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the link to that URL is fine. And adding this Builtin which still exists in WMA 13 is okay too. But all of this is a distraction from the next release. I'd appreciate it PRs could be more focused towards the next release.

"""

summary_text = (
"give a list of formatting transformation rules associated to a symbol."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

associated to -> associated with

@rocky
Copy link
Member

rocky commented Jan 19, 2025

LGTM - but again, please don't think about Formatting and Boxing until after the 8.0 release. Thanks.

@mmatera mmatera merged commit 3846c21 into master Jan 19, 2025
14 checks passed
@mmatera mmatera deleted the FormatValues branch January 19, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants