More on Builtin.contribute and Builtin.get_functions. #1298
+157
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the regular expression used in get_function to support multiline docstrings. * Fix how the full name of builtins are built in `contribute` when the class does not have a `context` attribute. * Add tests for Builtin.contribute
rocky
reviewed
Jan 18, 2025
mmatera
commented
Jan 18, 2025
mmatera
force-pushed
the
test_for_contribute_and_improving_that_method
branch
from
cb4b3ad to
604c18f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some missing details that I discovered regarding these methods, and a pytest to test the right behaviour:
contributewhen the class does not have acontextattribute.More tests can be added later.